Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix systemv logging #1096

Merged
merged 2 commits into from
Feb 3, 2018
Merged

Fix systemv logging #1096

merged 2 commits into from
Feb 3, 2018

Conversation

kardapoltsev
Copy link
Member

Fix tests in #1022

timcharper and others added 2 commits August 28, 2017 14:46
The current implementation has no effect; nothing is logged. '>>' seems
to be passed to the process as a parameter and not something that is
interpretted by the shell.

This approach is in line with the accepted solution suggested at
https://stackoverflow.com/a/21029952/183863

Fixes sbt#1021
Copy link
Collaborator

@dwickern dwickern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I already verified that the fix works on a Debian box so I'll merge as soon as the tests finish

@muuki88
Copy link
Contributor

muuki88 commented Jan 26, 2018

I restarted the one failed tests. Travis is here and there a bit unstable 😉
You are awesome folks ❤️

@muuki88 muuki88 merged commit 7bb9504 into sbt:master Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants