Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBT 1.1.1 #1102

Merged
merged 1 commit into from
Mar 27, 2018
Merged

SBT 1.1.1 #1102

merged 1 commit into from
Mar 27, 2018

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Feb 14, 2018

No description provided.

@joan38
Copy link
Contributor Author

joan38 commented Feb 15, 2018

How come upgrading SBT fails the build?

@dwickern
Copy link
Collaborator

That one failing travis job is trying to download from

http://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/1.1.1/sbt-launch.jar

instead of

http://repo.scala-sbt.org/scalasbt/maven-releases/org/scala-sbt/sbt-launch/1.1.1/sbt-launch.jar

🤔

@dwickern
Copy link
Collaborator

I saw this note about the new slash syntax:

Note: One caveat to the plugin authors is that if you use the new syntax in your plugin it will push the minimum required sbt version to 1.1.0-RC for your users.

Is this still true? If we change to the slash syntax, will we break compatibility? @eed3si9n

@eed3si9n
Copy link
Member

@dwickern sbt plugins are just libraries that use sbt. If you use slash syntax in the plugin part of the code it will push the minimum requirement since it will require function calls that sbt 1.0.x won't understand. You can still use it in your build.sbt.

@joan38
Copy link
Contributor Author

joan38 commented Feb 16, 2018

Hi,
I did use the slash syntax only in the build.sbt of the project, this shouldn’t push the minimum requirement.

@muuki88 muuki88 added the project General project issues label Feb 16, 2018
@muuki88
Copy link
Contributor

muuki88 commented Mar 24, 2018

Next try. I killed all build caches an restarted the failing job.
I'll at least want to figure out what's wrong, so that if we upgrade we
know how to fix this issue if travis ci has issues in another pull requests.

@joan38
Copy link
Contributor Author

joan38 commented Mar 24, 2018

Any luck?

@muuki88
Copy link
Contributor

muuki88 commented Mar 24, 2018

Nope 😔

@muuki88
Copy link
Contributor

muuki88 commented Mar 25, 2018

My bad. I should have looked at our .travis.yml first

# workaround for https://github.com/travis-ci/travis-ci/issues/4527
      before_script:
        - curl -L --create-dirs -o $HOME/.sbt/launchers/1.0.2/sbt-launch.jar http://dl.bintray.com/sbt/maven-releases/org/scala-sbt/sbt-launch/1.0.2/sbt-launch.jar

You need to adjust that line as well.

@joan38 joan38 force-pushed the sbt-1.1.1 branch 2 times, most recently from 3ef6f2c to 0920de4 Compare March 26, 2018 18:03
@joan38
Copy link
Contributor Author

joan38 commented Mar 27, 2018

All good @muuki88

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

@muuki88 muuki88 merged commit 0109648 into sbt:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project General project issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants