Add kill timeout to SystemD service as TimeoutStopSec #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrewgee, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Thanks @andrewgee for your pull request 😎 🤗 The change looks good to me. IMHO there are no tests required. The documentation is already there as well 😄 I'll wait for travis and then merge. |
muuki88
approved these changes
Sep 11, 2018
|
Thanks @muuki88! |
|
Hi @andrewgee, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Co-authored-by: Andrew Smitherim <[email protected]>
|
rebased |
|
Thanks for the rebase. I use the Github UI to squash and merge, so no worries 😁 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed the
killTimeoutSettingKeywasn't being used by the SystemD template. We've added it in similarly to howSuccessExitStatuswas addedCo-authored-by: Andrew Smitherim [email protected]