Allow the upstart job to be executed as a different user #116
Conversation
…fore changing owners on the filesystem
|
Hi @aparkinson, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
CLA now signed |
| @@ -18,7 +18,10 @@ respawn limit ${{retries}} ${{retryTimeout}} | |||
| # set the working directory of the job processes | |||
| chdir ${{chdir}} | |||
|
|
|||
| # changes to the user and group before running the job's process | |||
| setuid ${{daemon_user}} | |||
There was a problem hiding this comment.
Looks good to me (upstart doc). On which system did you test it?
There was a problem hiding this comment.
I've only tested with Ubuntu 12.04 LTS (Precise Pangolin)
It doesn't work for Ubuntu 10.04 LTS Lucid as setuid wasn't introduced until version 1.4 of upstart
|
Thanks for the contribution! Looks great to me. Would you also mind updating this with your feature? I'm trying to track our level of features/testing on the server archetype for the next release. I think we may just try to round out the linux packages first, then a different release for windows support. Thanks!
|
Allow the upstart job to be executed as a different user
|
@jsuereth I'll update the page with my findings. Awesome plugin, I'm trying to build deb of our Play! app for our continuous delivery pipeline so I'm sure we can help with testing and rounding out that side of the server archetype |
Running services as Root can be a security risk, upstart can start programmes as a different user just like SystemV