Add Travis tests for the GraalVL native-image plug-in #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
Oct 21, 2018
.travis.yml
Outdated
| @@ -16,6 +16,7 @@ cache: | |||
| - $HOME/.sbt | |||
| - $HOME/.m2 | |||
| - $HOME/.ivy2 | |||
| - $HOME/graalvm-ce-1.0.0-rc7 | |||
There was a problem hiding this comment.
rc8 has been released two days ago 😄
muuki88
requested changes
Oct 21, 2018
.travis.yml
Outdated
| @@ -36,6 +37,18 @@ before_install: | |||
|
|
|||
| before_script: | |||
| - curl -L --create-dirs -o $HOME/.sbt/launchers/1.2.6/sbt-launch.jar http://dl.bintray.com/sbt/maven-releases/org/scala-sbt/sbt-launch/1.2.6/sbt-launch.jar | |||
| # Make GraalVM `native-image` available and nothing else | |||
| - if [[ ! -d graalvm-ce-1.0.0-rc7 ]]; then | |||
There was a problem hiding this comment.
I guess the yml parser or what ever doesn't cope well with this bunch of code. My suggestion would be to add a .travis folder and place all travis related scripts in there and call them here in a single line, e.g.
- .travis/download-sbt
- .travis/download-graalvm
ScalaWilliam
force-pushed
the
travis-graal
branch
from
82def0a to
6e1ee23
Compare
|
All right @muuki88, it passed and then I squashed all the commits. Please take a look. |
Also move out the sbt downloader into the same directory as the downloader.
ScalaWilliam
force-pushed
the
travis-graal
branch
from
6e1ee23 to
fded7e1
Compare
muuki88
approved these changes
Oct 27, 2018
|
No need for squashing 😉 GitHub has a button for this 😎 |
|
You can merge after CI passed 👍 |
muuki88
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move out the sbt downloader into the same directory as the
downloader.