#1178 attempt at adding in rpm epochs #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, sounds good.
…--
Regards, Alexey
On Tue, Dec 11, 2018, 7:33 PM Ty Coghlan ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/scala/com/typesafe/sbt/packager/rpm/RpmMetadata.scala
<#1179 (comment)>
:
> @@ -222,6 +223,9 @@ case class RpmSpec(meta: RpmMetadata,
sb append ("Version: %s\n" format meta.version)
sb append ("Release: %s\n" format meta.release)
sb append ("Summary: %s\n" format meta.summary)
+
+ if (meta.epoch > 0) sb append ("Epoch: %d\n" format meta.epoch)
I went back and forth on that. Doing this way also protests against
negative epochs, but I suppose I could do an exists or filter for the
negative check. Thoughts?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABEFStilRVseAMi1aVqadKZRDJ_3cvOIks5u36YvgaJpZM4ZMQ8O>
.
|
muuki88
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Very solid change ❤️
Thanks @kardapoltsev for still being around and help reviewing 🤗
| @@ -28,3 +28,5 @@ rpmRelease := "1" | |||
| rpmVendor := "DemoVendor" | |||
|
|
|||
| rpmLicense := Some("Apache-2.0") | |||
|
|
|||
| rpmEpoch := 1 | |||
There was a problem hiding this comment.
Out of curiosity? This do you acutally run this test? I haven't used this for a very long time and I'm not sure if we should remove it.
There was a problem hiding this comment.
Whoops, I forgot that I committed this. I mucked around with the Vagrant file (e.g., changing chef to bento) and got something half running, but tbh you could probably remove it.
|
squashed and updated based on review comments |
|
Can someone poke the travis build? |
src/main/scala/com/typesafe/sbt/packager/validation/package.scala
Outdated
Show resolved
Hide resolved
|
LGTM |
|
🥂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.