Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log rpm output to error or info depending on exit code #1212

Merged
merged 1 commit into from
May 2, 2019
Merged

Log rpm output to error or info depending on exit code #1212

merged 1 commit into from
May 2, 2019

Conversation

Falmarri
Copy link
Contributor

No description provided.

@Falmarri Falmarri mentioned this pull request Mar 30, 2019
Merged
@anilkumarmyla
Copy link
Contributor

@Falmarri did you get to test this change?

@Falmarri
Copy link
Contributor Author

Falmarri commented Apr 2, 2019

I didn't test it by actually running it. But I don't see how this couldn't do what is desired 😨

@anilkumarmyla
Copy link
Contributor

It does work @Falmarri . Did a sbt publishLocal and tested resulting version in a project which logged all rpm build to info instead of error

@anilkumarmyla
Copy link
Contributor

any actions on this?

muuki88
muuki88 approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience 😄 I'm currently moving and on parental leave.

This makes sense. Thanks for improving this ❤️

@muuki88 muuki88 merged commit b274c32 into sbt:master May 2, 2019
@muuki88 muuki88 added the rpm label May 2, 2019
@muuki88 muuki88 mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilkumarmyla anilkumarmyla anilkumarmyla approved these changes

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
rpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Falmarri @anilkumarmyla @muuki88