Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #1218: docker:publishLocal fails because of non-existent gid #1219

Merged
merged 4 commits into from
May 2, 2019
Merged

Bug #1218: docker:publishLocal fails because of non-existent gid #1219

merged 4 commits into from
May 2, 2019

Conversation

NicolasRouquette
Copy link
Contributor

This is to demonstrate that #1218 is indeed a bug.
The fix will be provided in a subsequent commit.

@NicolasRouquette
Copy link
Contributor Author

Indeed, the PR added a new docker test for a non-existent daemon group ID that failed the test:
https://travis-ci.org/sbt/sbt-native-packager/jobs/526932828#L1273

@NicolasRouquette
Copy link
Contributor Author

This PR is ready for review.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug 🤗

Implementation and tests are looking good. I'm going to merge and release this. If there are any issues would you be okay to be mentioned in bug tickets? 😀

@muuki88 muuki88 merged commit 63000e0 into sbt:master May 2, 2019
@muuki88 muuki88 added the docker label May 2, 2019
@NicolasRouquette
Copy link
Contributor Author

I can help with troubleshooting docker-related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants