-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple jlink wrapper #1220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
World class pull request 😍
Let me check the travis.yml
to see if we can add a new java11 testing stage.
src/main/resources/com/typesafe/sbt/packager/archetypes/scripts/bat-template
Show resolved
Hide resolved
src/main/scala/com/typesafe/sbt/packager/archetypes/jlink/JlinkKeys.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/typesafe/sbt/packager/archetypes/jlink/JlinkPlugin.scala
Outdated
Show resolved
Hide resolved
Adding this to the - script: sbt "^validateJdkPackagerTravis"
name: "scripted jlink tests"
jdk: oraclejdk11
if: type = pull_request OR (type = push AND branch = master) Maybe after https://github.com/sbt/sbt-native-packager/blob/master/.travis.yml#L77 |
src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppKeys.scala
Outdated
Show resolved
Hide resolved
Done this, but I can't check that it works because of the MiMa problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your awesome work on this and brining jlink
to native-packager 🎉 🤗
The last nitpick can be fixed in a separate PR if you got the time 😄 I will release this immediately. Also thanks for making sure things are kept binary compatbile.
well 😂 , you have been faster then me writing my comment. |
version |
This scans the
fullClasspath
(usingjdeps
), and builds a JVM image (usingjlink
) from all the referenced modules. The image is then "mounted" to a configurable prefix inUniversal / mappings
(jre/
by default). The image location is then passed to the start scripts with the highest priority (higher thanJAVA_HOME
).Potential issues (feedback required):
jdeps
output. I'm not sure it is worth the trouble.java.*
,javafx.*
,jdk.*
), since everything else is already provided by theJavaAppPackaging
. I can think both of pros and cons to this - maybe this warrants adding a separate incision point for transforming the detected module list?