Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docker version detection #1231

Merged
merged 2 commits into from
May 24, 2019
Merged

Improve Docker version detection #1231

merged 2 commits into from
May 24, 2019

Conversation

eed3si9n
Copy link
Member

Fixes #1230

@eed3si9n eed3si9n mentioned this pull request May 23, 2019
Closed
@eed3si9n eed3si9n force-pushed the wip/dockerversion branch from 313737d to e81f3d3 Compare May 23, 2019 16:33
@muuki88 muuki88 added the docker label May 24, 2019
muuki88
muuki88 approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤗 Thanks for the effort @eed3si9n

@muuki88 muuki88 merged commit b9228fd into sbt:master May 24, 2019
@eed3si9n eed3si9n deleted the wip/dockerversion branch August 16, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

@TimMoore TimMoore TimMoore approved these changes

Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker version detection fails on Ubuntu 16.04
3 participants
@eed3si9n @TimMoore @muuki88