-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some documentation to the debian package. #127
Conversation
``src/debian/DEBIAN``. | ||
|
||
If you use the ``packageArchetype.java_server`` there are predefined ``postinst`` and | ||
``preinst`` files, which start/stop the application on install/remove calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth stating the packageArchetype.java_server
predefined scripts modif/extends any user defined src/debian/DEBIAN
scripts and does not replace them
Nice Job! |
Good points. :) I'll add the additions tomorrow. |
|
||
packageArchetype.java_application | ||
|
||
maintainer := "Max Smith <[email protected]>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice generic name. I like it. However, Max Fightmaster is a real person, and I feel would make this example pop :)
Improvements look great! just one miinor spelling issue. |
@@ -37,6 +37,8 @@ Debian requires the following specific settings: | |||
are placed in the ``DEBIAN`` file when building. Some of these files can be autogenerated, | |||
for example when using a package archetype, like server_application. Howeve, any autogenerated file | |||
can be overridden by placing your own files in the ``src/debian/DEBIAN`` directory. | |||
|
|||
`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this fixing up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no idea. Will remove this.
Just a side note on this PR: @muuki88 and @aparkinson I made you both committers thanks to the quality and dedication of your patches! I just added TravisCI integration to make merging PRs a bit easier. We're still in a void when it comes to OSX + Windows tests, so I can cover that. IF you'd like, after we have one of the three of us in agreement on a patch, it can be merged. I'll try to get the release procedure to something any of us could use. Thanks for your hard work on this project! |
Adding some documentation to the debian package.
Thanks @jsuereth |
Awesome :) With great power comes great responsibility. |
This what I actually want to do :)
Asking for review.