Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systemd mark file as non config #1351

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Systemd mark file as non config #1351

merged 2 commits into from
Jul 8, 2020

Conversation

tolikr
Copy link
Contributor

@tolikr tolikr commented Jul 7, 2020

Trying to resolve #1144

@lightbend-cla-validator
Copy link

Hi @tolikr,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@muuki88 muuki88 added the rpm label Jul 8, 2020
muuki88
muuki88 approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! ❤️ Thanks for fixing this issue after such a long time.

The change is so small, tests aren't necessary for this one.

@muuki88 muuki88 merged commit 07d7b84 into sbt:master Jul 8, 2020
@muuki88
Copy link
Contributor

muuki88 commented Jul 8, 2020

Release 1.7.4 is on its way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
rpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rpm should have option to make systemd file config
3 participants
@tolikr @lightbend-cla-validator @muuki88