Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for #76 #154

Merged
merged 2 commits into from
Feb 6, 2014
Merged

Adding tests for #76 #154

merged 2 commits into from
Feb 6, 2014

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Feb 5, 2014

  • check for scriptlets
  • check rpm version

* check for scriptlets
* check rpm version
@jsuereth
Copy link
Member

jsuereth commented Feb 5, 2014

Hmm, you may want to check the travisCI config file to make sure we have the appropriate RPM builder on the instance....

@muuki88
Copy link
Contributor Author

muuki88 commented Feb 5, 2014

The method to obtain the rpm version was not robust enough for different printings with rpm --version

@jsuereth
Copy link
Member

jsuereth commented Feb 6, 2014

Nice. Looks good to me.

jsuereth added a commit that referenced this pull request Feb 6, 2014
@jsuereth jsuereth merged commit bb8d1d9 into master Feb 6, 2014
@jsuereth jsuereth deleted the wip/rpm-tests branch February 6, 2014 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants