-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding automation for releasing *and* directly release to bintray. #157
Conversation
* Create helpers to ensure appropriate bintray setup. * Add mechanism to acknowledge (via REST) that a release is complete and good * Create release script to automatically tag/test/push packages and remember all the steps to actually ensure a bintray release is coherent, complete and basically working on linux. Windows can suffer as usual until we have more infrastructure.
val (u,p) = bintrayCreds(creds) | ||
import dispatch.classic._ | ||
// TODO - Log the output | ||
Http(url(uri).POST.as(u,p).>|) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this exactly do? Sometimes the symbolic operators are... difficult xD
POST something to uri with credentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just executes a POST with no parameters and ignores the response (but throws an exception on failure).
As far as I understand the different steps it looks good. Testing this is only possible, if we would release something, right? To do so, we would need to
credentials += Credentials("Bintray", "api.bintray.com", "muuki88", "bintray-password")
There is no |
The script is only designed for full releases. A few missing items I didn't mention:
Thanks for the review! |
Will you add the last three points in a followup commit or another pr? If pr we merge this |
I'm not familiar with TravisCI but could the release be done from there? It would mitigate against item 1. Check for no local git changes |
Probably another pr. Have to figure out the how first :)
|
@aparkinson good question. I don't know! |
TravisCI is not for releasing, only for testing AFAIK. |
K, anyone against merging this? @aparkinson @muuki88 ? |
Adding automation for releasing *and* directly release to bintray.
Nope. As this is only for us to use and it may take a while before @aparkinson or me will do a release you will have to struggle with your own code ;) Until then I try to test this code with a sample project. |
all the steps to actually ensure a bintray release is coherent, complete
and basically working on linux. Windows can suffer as usual until we
have more infrastructure.
Review/use by @muuki88 and @aparkinson