Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding automation for releasing *and* directly release to bintray. #157

Merged
merged 1 commit into from
Feb 11, 2014

Conversation

jsuereth
Copy link
Member

@jsuereth jsuereth commented Feb 6, 2014

  • Create helpers to ensure appropriate bintray setup.
  • Add mechanism to acknowledge (via REST) that a release is complete and good
  • Create release script to automatically tag/test/push packages and remember
    all the steps to actually ensure a bintray release is coherent, complete
    and basically working on linux. Windows can suffer as usual until we
    have more infrastructure.

Review/use by @muuki88 and @aparkinson

* Create helpers to ensure appropriate bintray setup.
* Add mechanism to acknowledge (via REST) that a release is complete and good
* Create release script to automatically tag/test/push packages and remember
  all the steps to actually ensure a bintray release is coherent, complete
  and basically working on linux.  Windows can suffer as usual until we
  have more infrastructure.
val (u,p) = bintrayCreds(creds)
import dispatch.classic._
// TODO - Log the output
Http(url(uri).POST.as(u,p).>|)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this exactly do? Sometimes the symbolic operators are... difficult xD
POST something to uri with credentials

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just executes a POST with no parameters and ignores the response (but throws an exception on failure).

@muuki88
Copy link
Contributor

muuki88 commented Feb 6, 2014

As far as I understand the different steps it looks good. Testing this is only possible, if we would release something, right? To do so, we would need to

  1. Create e.g. credentials.sbt with something like described here
credentials += Credentials("Bintray", "api.bintray.com", "muuki88", "bintray-password")
  1. Call sbt release 197074808556f43c8cd7d5473c1c61ec4b08446f

There is no SNAPSHOT deploy, right?

@jsuereth
Copy link
Member Author

jsuereth commented Feb 6, 2014

  1. Has to be "Bintray API Realm" for realm. Ivy is finicky there.
  2. sbt release v0.7.0-M3 was my test. We now have an M3 and the release script works quite well :)

The script is only designed for full releases. A few missing items I didn't mention:

  1. Check for no local git changes (clean repo) so tagging is exact
  2. Signing the tag.
  3. Help message for how to configure credentials when we detect there are none.

Thanks for the review!

@muuki88
Copy link
Contributor

muuki88 commented Feb 6, 2014

Will you add the last three points in a followup commit or another pr? If pr we merge this

@aparkinson
Copy link
Contributor

I'm not familiar with TravisCI but could the release be done from there?

It would mitigate against item 1. Check for no local git changes

@jsuereth
Copy link
Member Author

jsuereth commented Feb 6, 2014

Probably another pr. Have to figure out the how first :)
On Feb 6, 2014 12:55 PM, "Muki" [email protected] wrote:

Will you add the last three points in a followup commit or another pr? If
pr we merge this

Reply to this email directly or view it on GitHubhttps://github.com//pull/157#issuecomment-34350752
.

@jsuereth
Copy link
Member Author

jsuereth commented Feb 6, 2014

@aparkinson good question. I don't know!

@muuki88
Copy link
Contributor

muuki88 commented Feb 6, 2014

TravisCI is not for releasing, only for testing AFAIK.
@aparkinson You mean checking for local changes should be implemented before mergin?

@jsuereth
Copy link
Member Author

K, anyone against merging this? @aparkinson @muuki88 ?

muuki88 added a commit that referenced this pull request Feb 11, 2014
Adding automation for releasing *and* directly release to bintray.
@muuki88 muuki88 merged commit c0b0edd into master Feb 11, 2014
@muuki88 muuki88 deleted the bintray-releasing branch February 11, 2014 09:05
@muuki88
Copy link
Contributor

muuki88 commented Feb 11, 2014

Nope. As this is only for us to use and it may take a while before @aparkinson or me will do a release you will have to struggle with your own code ;)

Until then I try to test this code with a sample project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants