Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/package mapping tests #172

Merged
merged 5 commits into from
Feb 22, 2014
Merged

Wip/package mapping tests #172

merged 5 commits into from
Feb 22, 2014

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Feb 19, 2014

Adding some tests for the package mapping stuff before changing things any further.
Some of the LinuxPackageMapping methods should be refactored and the new
MappingsHelper should be used.


// Consider using mappings in Universal
linuxPackageMappings in Debian += packageDirectoryAndContentsMapping(
file("src/resources/conf") -> "/usr/share/conf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note, you should always do this relative to a directory, like (baseDirectory.value / "src/resources/conf") -> "/usr/share/conf"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll change this

@jsuereth
Copy link
Member

nice tests. Two comments.

muuki88 added a commit that referenced this pull request Feb 22, 2014
@muuki88 muuki88 merged commit cfe8ff8 into master Feb 22, 2014
@muuki88 muuki88 deleted the wip/packageMapping-tests branch February 22, 2014 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants