-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip/server permissions #174
Conversation
Since mostly we want default |
for((file, name) <- manPages) | ||
yield file -> (name + ".gz") | ||
for ((file, name) <- manPages) | ||
yield file -> (name + ".gz") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of using Scalariform, which although not my favorite style, will help prevent all of us from whitespace-line changing each other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm already using it through Eclipse (at least that's what the scalariform page says). However an integration in the build with sbt-scalariform would be helpful as everbody uses another IDE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preferences export from eclipse: https://dl.dropboxusercontent.com/u/2654300/formatterPreferences.properties
SO in terms of option 1 vs. Option 2, I'm on the fence. Both have desirable attributes. I'm leaning towards 2 though, for sbt.
linuxPackageMappings in Linux := (rawLinuxPackageMappings in Linux).value |
Merging this as-is for now. |
Implementing permissions as described in #174
DONE
This is a follow up to #170 discussions. The current state of the pull request contains
appUser
andappGroup
withdaemonUser
anddaemonGroup
MappingsHelper
defaultLinuxConfigLocation
TODO
Think of a way to create a permissions-table like this
Option 1: mapping-files-changer
A small API to change permissions for already-created mappings.
LinuxPackageMappings
may need to be split, as they contain a sequence of mappingschangePermissions(for = "/usr/share", LinuxFileMetaData(user = "daemonUser"))
Option 2: creating a permissions table
The idea is to define a setting, which can be queried for default permissions, like
Discussion
@aparkinson, @jsuereth, @kardapoltsev . What do you think?