Unify linux script replacements #182 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love the direction, but looks like one of the settings didn't cross over: |
|
@muuki88 I'll see if I can clean this up. Going to try to cut the RC1 today. Don't have much time for docs (I'm swamped writing the sbt 0.13.2 migration guide), but I'll do what I can :) |
|
Error message: |
|
Ok, found the issue & fixed, going to patch your branch shortly, then RC1 |
… plugin. * Before linux installation details were in the GenericPackageMappings * Now, we include template generation for linux control scripts in the linux plugin. This means, we need the settings we depend on in the more generic location, as not all usages of the plugin will include the generic mappings. Review by @muuki88
|
@muuki88 Take a gander at the fix, and merge when you're comfortable. I'll push the RC1 right after that. Great work! |
muuki88
added a commit
that referenced
this pull request
Mar 12, 2014
Unify linux script replacements #182
|
Awesome @jsuereth . Let's to the release |
|
script is doing its thing right now! I just have to do release notes/announcement next :) |
|
Can I watch you doing the process? I'll be online in Skype/hangout in 20 minutes. |
|
Sure, google + is easier if you're on it. Ping me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing useless code, adding more tests and unifying script replacements.