Fix #195 Adding rpmBrpJavaRepackJars setting #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOOH, nice fix. I actually disabled this on my RPM building system directly, so I had forgotten all about redhat's crazy notion of repackaging JARs. Personally, I think we may want this to be the default. The JAR repackaging is a serious problem IMHO for the style of thing we're distributing. |
|
BTW LGTM. |
|
The default behavior is disabling the repacking. Packaging works for me as expected. However I cannot check if the performance issue is resolved. @timperret I will merge this and if it doesn't help, we'll reopen the ticket. |
muuki88
added a commit
that referenced
this pull request
Mar 26, 2014
Fix #195 Adding rpmBrpJavaRepackJars setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activated with
A the
__os_install_postmacro will be added to therpmPre in Rpmsetting and jar repacking is disabled.http://swaeku.github.io/blog/2013/08/05/how-to-disable-brp-java-repack-jars-during-rpm-build/
@timperrett can you verify this?