Fixes #175 - Staging does not clear previous files. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use sync when copying to staging directory * Add test to make sure incrementally removing files shows up correctly. NOTE: we may need to feed this through all our staging, e.g. when generating MSIs or RPMs or DEBs.
| private[this] def stageFiles(config: String)(cacheDirectory: File, to: File, mappings: Seq[(File, String)]): Unit = { | ||
| val cache = cacheDirectory / ("packager-mappings-" + config) | ||
| val copies = mappings map { | ||
| case (file, path) => file -> (to / path) |
There was a problem hiding this comment.
I like the variable names 👍
|
Only one small question. Besides that LGTM |
muuki88
added a commit
that referenced
this pull request
Mar 27, 2014
Fixes #175 - Staging does not clear previous files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: we may need to feed this through all our staging, e.g. when generating
MSIs or RPMs or DEBs.
Fixes #175 (Not sure why github requires that here as well as title...)
Review by @muuki88 or @aparkinson