support RPM 'Prefix'. #242
Conversation
| @@ -11,6 +11,7 @@ trait RpmKeys { | |||
| val rpmVendor = SettingKey[String]("rpm-vendor", "Name of the vendor for this RPM.") | |||
| val rpmOs = SettingKey[String]("rpm-os", "Name of the os for this RPM.") | |||
| val rpmRelease = SettingKey[String]("rpm-release", "Special release number for this rpm (vs. the software).") | |||
| val rpmPrefix = SettingKey[Option[String]]("rpm-prefix", "File system prefix for relocatable package.") | |||
There was a problem hiding this comment.
Wouldn't there need to be a default value for this in the acrchetypes as well?
There was a problem hiding this comment.
Maybe? Prefix: is not a required field what would you think it would be?
There was a problem hiding this comment.
I'm not familiar with the prefix option. What's its purpose?
There was a problem hiding this comment.
@jayaras is right. By default this should be None as this field is optional and only for special use cases.
|
I'm all for adding the ability to have a prefix, but for RPMs we autogenerate, shouldn't we be taking it into account? |
|
@jsuereth What do you mean exactly? Perhaps there is a better approach to handle the situation where one uses prefix in general as I had to make several changes to various parts to make it play nice. -j |
|
Guess I'd like to see the changes. I feel out of the box would make sense.
|
|
https://gist.github.com/jayaras/7ad6fe2331a427db589a has what i've changed to make it play nice. |
|
I had some time to read about the IMHO it's nice to have this option, but a documentation section is definitely needed if people want to use this. The gist is perfect starting point. Long comment, short fazit. Code looks fine, documentation would be awesome. Small manual for the docs:
|
|
I don't think its a common use case. The rpm.org docs on it have an odd example of moving a command line cd player around. My use case is mostly this is the legacy way we roll packages here. I think the only people who want to use this are going to be doing something not so standard like I am. thanks I'll work on some docs in the coming days |
|
added some info on the docs are we safe to merge? |
|
Awesome. As this is turned off by default it should be fine. If you have time to write a small test this would be even better ;) |
|
@kardapoltsev , if you got time can you check on this? Code looks good to me, but additional verification from you wouldn't hurt :) |
|
I'm not very familiar with rpm but code looks good to me too. Nice work, @jayaras ) |
|
Works on my machine. We should add a test at somepoint for this. |
This lets you set the Prefix: meta info in the event you want to create a relocatable package.