Do not try to setup missing deployment settings for Docker. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker has no tasks for packageBin/etc. It should not be mentioned in the deploymentSettings definition. Otherwise, adding deploymentSettings to your build results in: Reference to undefined setting: docker:packageBin from docker:$local (build.sbt:3)
|
LGTM, once travis has a chance to verify. |
|
This is also affecting me; Travis CI says its good to go :-) |
muuki88
added a commit
that referenced
this pull request
May 16, 2014
Do not try to setup missing deployment settings for Docker.
|
Thanks a lot for your effort @garycoady 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker has no tasks for packageBin/etc. It should not be mentioned
in the deploymentSettings definition. Otherwise, adding
deploymentSettings to your build results in:
Reference to undefined setting:
docker:packageBin from docker:$local (build.sbt:3)