Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong usage of brackets in upstart script #262

Merged
merged 2 commits into from
May 22, 2014

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented May 21, 2014

No description provided.

@kardapoltsev
Copy link
Member

Thanks! Next time I'll not only scripted tests, but actual work on system. Sorry for this mistake..

@muuki88
Copy link
Contributor Author

muuki88 commented May 21, 2014

No problem :) I think we need to pull-off a minor release as this is a big deal.

@paddymahoney
Copy link

Hello @muuki88 and @kardapoltsev
Just a question - does this affect the upstart script starting post-inst on 0.7.1?

@kardapoltsev
Copy link
Member

Yes, it is.

@kardapoltsev
Copy link
Member

Build failed because we need same changes in test))

@paddymahoney
Copy link

Let me know if you would like someone to verify a fix.

@kardapoltsev
Copy link
Member

Since we could have smth like

start on (filesystem and static-network-up) or failsafe-boot

may be it'll be better to remove brackets at all? And let users write what they want in requiredStartFacilities ?

@muuki88
Copy link
Contributor Author

muuki88 commented May 22, 2014

@kardapoltsev , yes this is a good solution. I will change the code accordingly

@muuki88
Copy link
Contributor Author

muuki88 commented May 22, 2014

@paddymahoney , if you could verify this, that would be awesome :)

@kardapoltsev
Copy link
Member

LGTM.

@muuki88
Copy link
Contributor Author

muuki88 commented May 22, 2014

Run's smoothly on ubuntu.

muuki88 added a commit that referenced this pull request May 22, 2014
Fixing wrong usage of brackets in upstart script
@muuki88 muuki88 merged commit ed929e8 into master May 22, 2014
@muuki88 muuki88 deleted the wip/upstart-startup-fix branch May 22, 2014 09:48
@paddymahoney
Copy link

@muuki88 @kardapoltsev I can confirm that 0.7.2-RC1 corrects the issue for me. Runs smoothly post-inst. Thanks for your work.

@muuki88
Copy link
Contributor Author

muuki88 commented May 22, 2014

Thanks for verifying this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants