First refactoring to provide multiple debian packaging strategies #284
Conversation
It's far from being ready for a pull request I have some questions that you may discover in the code itself
| libraryDependencies += "org.apache.commons" % "commons-compress" % "1.4.1" | ||
| libraryDependencies ++= Seq( | ||
| "org.apache.commons" % "commons-compress" % "1.4.1", | ||
| "org.vafer" % "jdeb" % "1.2" artifacts (Artifact("jdeb", "jar", "jar")) |
There was a problem hiding this comment.
Ah nice, I had been watching this guy.
There was a problem hiding this comment.
We are using the jdeb library at our company without any problems. The
artifacts (Artifact("jdeb","jar","jar")) part was the hardest to get :P
|
WOW, besides architectural concerns with CAKE, this LGTM!! Great work. |
|
Thanks Josh :) What are the alternatives to the current cake-pattern? I tried to build it like the rest of the plugin. We can create |
|
@muuki88 Yeah, the alternative is to just put things in objects and then import. The ugly part there is the Keys. For the users we want ALL keys to be in one object they can import, so we'd possibly have some uglyness with all our Keys in one "god" object. Your code is fine as is, and can be merged. I was just curious what your feelings were on the cake. We're almost at the breaking point where it gets to be more confusing than helpful in terms of partitioning functionality :) If you're still ok (and this PR looks great) feel free to merge. |
|
Exactly @jsuereth ! The decomposition (no matter which pattern) just works for the settings/tasks :( The keys always stay in a single, well yeah "god", object. The cake pattern was fine, I just couldn't thought of a solution for the keys. So for me the cake pattern is fine, as long as it's used not too much. I advised @laguiz to use it as well for his windows-service pr. So we'll get more cake :) |
First refactoring to provide multiple debian packaging strategies
This is the first refactoring step to provide an additional java-based debian packaging implementation.
Does this look okay from the coding side? @jsuereth , @kardapoltsev , @aparkinson ?
I basically introduced two new task
debianJDebPackaginganddebianNativePackaging.You set the packaging strategy with
packageBin in Debian <<= debianJDebPackaging in Debian.