Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StringUtilities.normalize to allow compilation with SBT 0.12. #288

Merged
merged 1 commit into from
Jul 2, 2014
Merged

Use StringUtilities.normalize to allow compilation with SBT 0.12. #288

merged 1 commit into from
Jul 2, 2014

Conversation

fiadliel
Copy link
Contributor

@fiadliel fiadliel commented Jul 2, 2014

Project.normalizeModuleID is recommended for use with SBT 0.13, but it
doesn't exist with 0.12. This uses the deprecated call instead.

Project.normalizeModuleID is recommended for use with SBT 0.13, but it
doesn't exist with 0.12. This uses the deprecated call instead.
@muuki88
Copy link
Contributor

muuki88 commented Jul 2, 2014

This looks okay to me, but I'm not sure if we need it. See my last comment

@fiadliel
Copy link
Contributor Author

fiadliel commented Jul 2, 2014

I was trying to cross-build against scala 2.9/sbt 0.12, with sbt +publishLocal

[info] Set current project to sbt-native-packager (in build file:/Users/gcoady/docker/sbt-native-packager/upstream/sbt-native-packager/)
[info] Setting version to 2.9.2
[info] Set current project to sbt-native-packager (in build file:/Users/gcoady/docker/sbt-native-packager/upstream/sbt-native-packager/)

[error] /Users/xxx/git/sbt-native-packager/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala:161: value normalizeModuleID is not a member of object sbt.Project
[error]       normalizedName <<= name apply Project.normalizeModuleID,
[error]                                             ^

And it looks like the plugin is still published for SBT 0.12: https://bintray.com/sbt/sbt-plugin-releases/sbt-native-packager/0.7.1/view/files/com.typesafe.sbt/sbt-native-packager/scala_2.9.2/sbt_0.12

@fiadliel
Copy link
Contributor Author

fiadliel commented Jul 2, 2014

Though perhaps you meant that you will implement packageName before the next release, so this code will be removed? Anyway, this fixes the current compilation failure on master.

@muuki88 muuki88 added the bug label Jul 2, 2014
@muuki88
Copy link
Contributor

muuki88 commented Jul 2, 2014

Yeah. You're right, even we change this later this will fix the issue temporary.

muuki88 added a commit that referenced this pull request Jul 2, 2014
Use StringUtilities.normalize to allow compilation with SBT 0.12.
@muuki88 muuki88 merged commit a162117 into sbt:master Jul 2, 2014
@fiadliel
Copy link
Contributor Author

fiadliel commented Jul 2, 2014

Thanks!

@fiadliel fiadliel deleted the wip/docker-fix-normalized-name branch July 2, 2014 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants