Remove cross-build configuration from build.sbt. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sbt-native-packager only supports SBT 0.13+, then scala 2.10 is the required version for the API.
|
Hi @fiadliel, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
Signed. |
|
Ah, this is the continuation of dropping support for sbt 0.12.x in master. CC> @muuki88 just to check this. |
|
Also, thanks for the fixes! |
|
Nice. Retriggered the build because of travis issues. |
muuki88
added a commit
that referenced
this pull request
Jul 25, 2014
Remove cross-build configuration from build.sbt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sbt-native-packager only supports SBT 0.13+, then scala 2.10
is the required version for the API.
Example errors with "sbt +compile" because SBT 0.13 uses macros:
[error] error while loading package, class file needed by package is missing.
[error] reference value internal of package scala.reflect.macros refers to nonexisting symbol.
[error] error while loading package, class file needed by package is missing.
[error] reference value internal of package scala.reflect.macros refers to nonexisting symbol.
[error] error while loading ProjectExtra, class file needed by ProjectExtra is missing.
[error] reference value internal of package scala.reflect.macros refers to nonexisting symbol.
[error] error while loading ProjectExtra, class file needed by ProjectExtra is missing.
[error] reference value internal of package scala.reflect.macros refers to nonexisting symbol.
[error] error while loading Def, class file needed by Def is missing.