Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11 debian symlinks now absolute. Maybe by default for all? #40

Merged
merged 1 commit into from
Sep 23, 2013
Merged

Fix #11 debian symlinks now absolute. Maybe by default for all? #40

merged 1 commit into from
Sep 23, 2013

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Sep 23, 2013

No description provided.

@jsuereth
Copy link
Member

Thanks for the fix. It may be the RPM was the issue with absolute symlinks. I also want to fix realpath too. I'll pull down and run through my scripted test suite.

P.S. Did you run sbt> scripted debian/* ?

jsuereth added a commit that referenced this pull request Sep 23, 2013
Fix #11 debian symlinks now absolute. Maybe by default for all?
@jsuereth jsuereth merged commit dc11fe1 into sbt:master Sep 23, 2013
@jsuereth
Copy link
Member

Ok, just to follow up, we now have debian violations because we're using absolute links when we should not be.

Here are the total errors/warning we have:

E: sbt: file-in-usr-marked-as-conffile usr/share/sbt-launcher-package/conf/sbtopts
E: sbt: file-in-usr-marked-as-conffile usr/share/sbt-launcher-package/conf/sbtconfig.txt
W: sbt: virtual-package-depends-without-real-package-depends depends: java2-runtime
W: sbt: symlink-should-be-relative usr/bin/sbt /usr/share/sbt-launcher-package/bin/sbt

The first is about /usr/ being mounted read-only, so our configuration is not editable (a serious issue we should look at fixing, I'm just not sure what to do about that).

The second is that if a symlink in /usr/ and the file itself is, you should use a relative symlink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants