Added translation of jvmopts contents and enhanced example app.
#494
Conversation
… to `javapackager`.
* master: Update README.md Replace chmod call More comprehensive tests Adding documentation FIX sbt#276 creating directories as necessary and specify top level dir and sadly realizing that apache commons compress is still the best bet Adding documentation, examples and tests. Initial refactoring on sbt#453 Revert "[fix sbt#472] /etc/default/<package-name> should be shell script setting envars" FIX sbt#489: Small fix in documentation Upgrading to java 7 and using posix nio API Conflicts: src/main/scala/com/typesafe/sbt/packager/jdkpackager/JDKPackagerHelper.scala
| // val cp = classpath.map(p ⇒ "lib/" + p) | ||
| // val cpStr = cp.mkString(cpSep) | ||
| // Make a setting? | ||
| val jvmOptsFile = (sourceDir ** "jvmopts").getPaths.headOption.map(file) |
There was a problem hiding this comment.
jvmOpts, etc-default and so forth have been part of a lot of discussions now.
We still need some work here, but this affects sbt-native-packager as a whole
There was a problem hiding this comment.
My vote would be for a setting that specifies the JVM options as a Seq[String], and not rely on some external source file with some one-off format (fine with me if it's converted to a source file as a part of universal:packageBin.) Almost went that route with this plugin, but I worked hard to avoid introducing any new constructs here.
There was a problem hiding this comment.
but I worked hard to avoid introducing any new constructs here
And you have done a great job here :)
The application configuration has a real big scope. Hopefully there is some time
to finish the discussion in #82 and find a proper solution. I like your idea of generating
the jvmopts or etc-default files from build settings.
|
LGTM. Currently I have a lot more time, so I hope to get this released soon. |
Added translation of `jvmopts` contents and enhanced example app.
Added this so standard JVM options encoded in the
con/jvmoptsfile are translated and passed on tojavapackager.