-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commit on #35 #53
Conversation
This doesn't work: debianMakePrermScript in Debian := Some(baseDirectory.value / "debian" / "prerm") (Changed some typos)
This works debianMakePrermScript := Some(sourceDirectory.value / "deb" / "control" / "prerm") when you leave out the Default valuesI think furthermore we should provide default directories to put in the scripts, like jdeb does. In this case
What do you think? |
I'm all about that. We already have a What about Combined with the "in Debian" fixes, I'll merge this and see if I can hook that mechanism. I have some cleanup I have to do here before the next release (see open bugs about scripts). |
@@ -44,18 +44,27 @@ trait DebianPlugin extends Plugin with linux.LinuxPlugin { | |||
packageSummary in Debian <<= packageSummary in Linux, | |||
maintainer in Debian <<= maintainer in Linux, | |||
debianMaintainerScripts := Seq.empty, | |||
debianMakePreremScript := None, | |||
debianMakePreinstScript := None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See how these don't specify "in Debian". That's one of oyur answers.
Fixes look great! Thanks much. |
Okay, nice. Should I provide a second pull-request for the default configuration? |
Up to you :) Any fixes welcome. |
This doesn't work:
debianMakePrermScript in Debian := Some(baseDirectory.value / "debian" /
"prerm")
(Changed some typos)