Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit on #35 #53

Merged
merged 1 commit into from
Oct 25, 2013
Merged

First commit on #35 #53

merged 1 commit into from
Oct 25, 2013

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Oct 24, 2013

This doesn't work:
debianMakePrermScript in Debian := Some(baseDirectory.value / "debian" /
"prerm")

(Changed some typos)

This doesn't work: 
debianMakePrermScript in Debian := Some(baseDirectory.value / "debian" /
"prerm")

(Changed some typos)
@muuki88
Copy link
Contributor Author

muuki88 commented Oct 25, 2013

This works

debianMakePrermScript := Some(sourceDirectory.value / "deb" / "control" / "prerm")

when you leave out the in Debian. Why?

Default values

I think furthermore we should provide default directories to put in the scripts, like jdeb does. In this case src/deb/control. And a nice feature is to filter the files to insert build specific variables. For example in the preinst

echo "Installing ${name}"

What do you think?

@jsuereth
Copy link
Member

I'm all about that. We already have a src/debian directory from which we should automatically pull files for the distribution.

What about src/debian/DEBIAN, since normally you place these in a DEBIAN directory?

Combined with the "in Debian" fixes, I'll merge this and see if I can hook that mechanism. I have some cleanup I have to do here before the next release (see open bugs about scripts).

@@ -44,18 +44,27 @@ trait DebianPlugin extends Plugin with linux.LinuxPlugin {
packageSummary in Debian <<= packageSummary in Linux,
maintainer in Debian <<= maintainer in Linux,
debianMaintainerScripts := Seq.empty,
debianMakePreremScript := None,
debianMakePreinstScript := None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how these don't specify "in Debian". That's one of oyur answers.

@jsuereth
Copy link
Member

Fixes look great! Thanks much.

jsuereth added a commit that referenced this pull request Oct 25, 2013
@jsuereth jsuereth merged commit 8f94469 into sbt:master Oct 25, 2013
@muuki88
Copy link
Contributor Author

muuki88 commented Oct 25, 2013

Okay, nice. Should I provide a second pull-request for the default configuration?

@jsuereth
Copy link
Member

Up to you :) Any fixes welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants