Fix warnings from rpm lint #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix warning from start script about [lockfile name](https://github.com/matwey/rpmlint/blob/67aec2b86e24d67b0674f4a0a17ac9f9c76ba736/InitScriptCheck.py#L256) - don’t mark SystemV init script as `%config`
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| exec="${{chdir}}/bin/${{exec}}" | |||
| prog="${{app_name}}" | |||
| lockfile=/var/lock/subsys/$prog | |||
| lockfile="/var/lock/subsys/${{app_name}}" | |||
There was a problem hiding this comment.
Interessting. This leads to the rpmlint error, because rpm doesn't substitute the variables?
There was a problem hiding this comment.
Yeah, if it detects $… then it issues a warning as it can’t resolve the substitution. Otherwise, it’s an error.
|
There's a failing test. The test is here |
from commit 7e8d703, script is no longer marked `%config`
| @@ -25,7 +25,7 @@ TaskKey[Unit]("check-spec-file") <<= (target, streams) map { (target, out) => | |||
| val spec = IO.read(target / "rpm" / "SPECS" / "rpm-package.spec") | |||
| out.log.success(spec) | |||
| assert(spec contains "%attr(0644,root,root) /usr/share/rpm-package/lib/rpm-test.rpm-test-0.1.0.jar", "Wrong installation path\n" + spec) | |||
| assert(spec contains "%config %attr(0755,root,root) /etc/init.d/rpm-package", "Wrong /etc/init.d path\n" + spec) | |||
| assert(spec contains "%attr(0755,root,root) /etc/init.d/rpm-package", "Wrong /etc/init.d path\n" + spec) | |||
from commit 7e8d703, script is no longer marked `%config`
|
Ahhh... same error in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%config