Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker on windows #573 #588

Merged
merged 1 commit into from
May 27, 2015
Merged

Use docker on windows #573 #588

merged 1 commit into from
May 27, 2015

Conversation

sjeandeaux
Copy link
Contributor

When native-packager add a folder in Dockerfile, it uses "File.separator" but this add doesn't depend to context of build.

@muuki88 muuki88 added the docker label May 26, 2015
@muuki88
Copy link
Contributor

muuki88 commented May 26, 2015

thanks for your request. can you squash the commits to one commit?

@sjeandeaux
resolve #573
f521679 
When we add folder in Dockerfile, we always use separator UNIX.
@sjeandeaux
Copy link
Contributor Author

it's done.

muuki88 added a commit that referenced this pull request May 27, 2015
@muuki88
Merge pull request #588 from sjeandeaux/master
9a1ad1e 
Use docker on windows #573
@muuki88 muuki88 merged commit 9a1ad1e into sbt:master May 27, 2015
@aj-michael aj-michael mentioned this pull request Sep 15, 2015
Merged
@oporkka oporkka mentioned this pull request Jun 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjeandeaux @muuki88