-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Docker plugin portable so that Windows is supported #765
Conversation
Thanks for your pull request. Can you fix the compile error and squash the commits?
|
fed46ca
to
0fe4615
Compare
Ah sorry, forgot that addition. Pushed a new commit now. |
@fiadliel do you have a windows computer at hand to verify it works? |
I'll add that I have only tested this on Linux myself (I have troubles running Docker-Virtualbox inside Virtualbox), the error was reported to me by another. |
@mkotsbak no problem :) Most of the contributors use Mac/Linux, so this is only a safety choice to have it confirmed by some systems ( we all know the "it works on my machine ;) ), as the roundtrip time for windows fixes is usually longer. |
0fe4615
to
101311e
Compare
I don't, but I'll try and rope in a friend to try the changes. (Windows has been quite the endangered species in any place I've worked for, for a long time). |
@@ -19,6 +19,7 @@ import packager.Keys._ | |||
import linux.LinuxPlugin.autoImport.{ daemonUser, defaultLinuxInstallLocation } | |||
import universal.UniversalPlugin.autoImport.stage | |||
import SbtNativePackager.{ Universal, Linux } | |||
import java.io.File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it now.
I will merge this after the |
Closes #760.