Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker plugin portable so that Windows is supported #765

Merged
merged 1 commit into from
Apr 24, 2016

Conversation

mkotsbak
Copy link

@mkotsbak mkotsbak commented Apr 2, 2016

Closes #760.

@muuki88
Copy link
Contributor

muuki88 commented Apr 3, 2016

Thanks for your pull request. Can you fix the compile error and squash the commits?

[error] /home/travis/build/sbt/sbt-native-packager/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala:64: not found: value File
[error]   val SeparatorChar = File.separatorChar
[error] 

@mkotsbak mkotsbak force-pushed the fix_760_docker_fails_on_Windows branch from fed46ca to 0fe4615 Compare April 3, 2016 12:13
@mkotsbak
Copy link
Author

mkotsbak commented Apr 3, 2016

Ah sorry, forgot that addition. Pushed a new commit now.

@muuki88
Copy link
Contributor

muuki88 commented Apr 4, 2016

@fiadliel do you have a windows computer at hand to verify it works?

@mkotsbak
Copy link
Author

mkotsbak commented Apr 4, 2016

I'll add that I have only tested this on Linux myself (I have troubles running Docker-Virtualbox inside Virtualbox), the error was reported to me by another.

@muuki88
Copy link
Contributor

muuki88 commented Apr 4, 2016

@mkotsbak no problem :) Most of the contributors use Mac/Linux, so this is only a safety choice to have it confirmed by some systems ( we all know the "it works on my machine ;) ), as the roundtrip time for windows fixes is usually longer.

@mkotsbak mkotsbak force-pushed the fix_760_docker_fails_on_Windows branch from 0fe4615 to 101311e Compare April 5, 2016 12:51
@fiadliel
Copy link
Contributor

fiadliel commented Apr 5, 2016

I don't, but I'll try and rope in a friend to try the changes. (Windows has been quite the endangered species in any place I've worked for, for a long time).

@@ -19,6 +19,7 @@ import packager.Keys._
import linux.LinuxPlugin.autoImport.{ daemonUser, defaultLinuxInstallLocation }
import universal.UniversalPlugin.autoImport.stage
import SbtNativePackager.{ Universal, Linux }
import java.io.File
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it now.

@muuki88
Copy link
Contributor

muuki88 commented Apr 24, 2016

I will merge this after the 1.1.0 release.

@muuki88 muuki88 merged commit 0a212be into sbt:master Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants