Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemonStdoutLogFile setting implemented #772

Merged
merged 1 commit into from
Apr 24, 2016

Conversation

kardapoltsev
Copy link
Member

I hope that this PR will not brake current Rpm behaviour.

@muuki88
Copy link
Contributor

muuki88 commented Apr 11, 2016

@kardapoltsev thanks for your PR. The purpose is to provide a stdout logfile for systemv, right?

Some tests failed due to a different script layout:

[error]     rpm / path-override-rpm
[error]     rpm / sysvinit-rpm
[error]     rpm / test-executableScriptName

@kardapoltsev
Copy link
Member Author

The purpose is to provide a stdout logfile for systemv, right?

Yes.
Most of rpm tests failed on my mac due to unspecified rpmGroup config. I'll check failed tests and fix them soon.

@kardapoltsev
Copy link
Member Author

@muuki88 could you take a look at this PR? I'm not sure about right order and scopes of setting overrides.

@muuki88
Copy link
Contributor

muuki88 commented Apr 23, 2016

Sorry @kardapoltsev , I completely forgot this one. Will take a look tomorrow.

@muuki88
Copy link
Contributor

muuki88 commented Apr 24, 2016

LGTM. The settings overrides and scope look correctly.

@muuki88 muuki88 merged commit cdc207e into sbt:master Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants