Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated java Docker image with openjdk #877

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

NeQuissimus
Copy link
Contributor

As per https://hub.docker.com/_/java/ the default java images have been deprecated in favor of openjdk (https://hub.docker.com/_/openjdk/) and will no longer receive updates after this year.

This change is replacing the references to java:latest with openjdk:latest both in code and documentation.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping native-packager up-to-date.
Small typo and then this is ready to merge.

@@ -9,7 +9,7 @@ version := "0.1.0"
maintainer := "Gary Coady <[email protected]>"

dockerCommands := Seq(
Cmd("FROM", "dockerfile/java:latest"),
Cmd("FROM", "dockerfile/openhdk:latest"),
Cmd("MAINTAINER", maintainer.value),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_j_dk 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet so far :D

@muuki88 muuki88 merged commit 050b329 into sbt:master Sep 19, 2016
@muuki88 muuki88 added the docker label Sep 19, 2016
@NeQuissimus NeQuissimus deleted the docker-openjdk branch September 19, 2016 12:16
edouardKaiser pushed a commit to edouardKaiser/sbt-native-packager that referenced this pull request Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants