"docker push" should support dockerExecCommand #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2016 15:54
…s on /var/run/docker.socket have restricted access, preventing Docker build and push commands from executing without severely compromising the system. See http://www.projectatomic.io/blog/2015/08/why-we-dont-let-non-root-users-run-docker-in-centos-fedora-or-rhel/ Therefore, I've added a new setting which supports replacing the default docker shell exec command so that I can instead use `sudo docker`, which is the recommended method for executing Docker on CentOS, Fedora and RHEL. What I don't want to do is run SBT as root - this will cause the working directory, and the ivy cache to become polluted with artifacts that are owned by root. It's best to limit the use of escalated privileges to just those commands that require them to avoid this pollution. So, to avoid: sudo sbt docker:publishLocal sbt clean <=== will fail because "target" is now owned by root
I was certain that I made this change initially - perhaps it got lost during some of my rebasing. The "docker push" should also support the dockerExecCommand setting.
|
... and sorry for the noisy PR! I should have started a new branch since you already merged the previous PR. |
|
OMG! You were not the only one :D |
muuki88
approved these changes
Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I missed this in #910.
I was certain that I made this change initially - perhaps it got lost during some of my rebasing.
The "docker push" command should also support the dockerExecCommand setting.