Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating etc default, different postinst script for sysvinit #93

Merged
merged 2 commits into from
Dec 2, 2013

Conversation

kardapoltsev
Copy link
Member

No description provided.

@@ -0,0 +1 @@
service ${{app_name}} start || echo "${{app_name}} could not be started. Try manually with service ${{app_name}} start"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other postinst also does user/group additions. Do you want that in here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At DebianPlugin.scala:159

IO.append(postinst, TemplateWriter.generateScript(DebianPlugin.postinstGroupaddTemplateSource, replacements))

I think this should append users and groups additions in any postinst. But I also think that this operations should be prepended.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, prepending sort of makes sense. What makes better sense is to somehow document that users can either specify where this gets injected in a script (via some comment/flag) OR we prepend.

@kardapoltsev
Copy link
Member Author

Should I do any additional changes in this PR? Users and group additions works fine except that it's appended to postints, not prepended.

@jsuereth
Copy link
Member

jsuereth commented Dec 2, 2013

Nah, looks fine, thanks for answering my question!

jsuereth added a commit that referenced this pull request Dec 2, 2013
generating etc default, different postinst script for sysvinit
@jsuereth jsuereth merged commit 61e8b64 into sbt:master Dec 2, 2013
@kardapoltsev kardapoltsev deleted the wip/etc-default branch December 3, 2013 03:56
@kardapoltsev
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants