Use SNAPSHOT for release when snapshot version #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @keirlawson, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
I have signed the Lightbend CLA |
muuki88
requested changes
Jun 6, 2017
|
|
||
| rpmLicense := Some("BSD") | ||
|
|
||
|
|
There was a problem hiding this comment.
A simple test task checking the rpmVersion would be nice. E.g. something like
TaskKey[Unit]("unzip") := {
assert(rpmRelease.value === "SNAPSHOT", s"RPM has incorrect value ${rpmVersion.value}")
assert(rpmMetadata.value.version === "...", s"RPM has incorrect value ${rpmMetadata.value.version}")
()
}| @@ -59,11 +59,16 @@ object RpmPlugin extends AutoPlugin { | |||
|
|
|||
| } | |||
|
|
|||
| private def stripSnapshot(version: String): String = { | |||
There was a problem hiding this comment.
I would put the private methods at the bottom of the AutoPlugin to preserve a "general -> detailed" structure :)
|
Have moved helper method and added tests as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #971 - feedback appreciated!