Git: only push released tag #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private def pushTags = cmd("push", "--tags", trackingRemote) | ||
| private def pushTags = { | ||
| val lastTag = (cmd("for-each-ref", "--count=1", "--sort=-taggerdate", "--format", "%(tag)", "refs/tags") !!). | ||
| linesIterator.next() |
There was a problem hiding this comment.
This feels a bit fragile - we know what the tag was because we tagged it, so we should use that. It will require a change to the signature of pushChanges, to take the tag (maybe an option of the tag), and it'll also require storing the tag in the state.
|
I also realized that the best would be change the signature as the tag is known. Some VCSs might not support getting the last added tag as in my change. It works but I agree with your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using git and performing a release all tags will be pushed and not only the released tag. This produces an error that tags already exists. This pull request will change that behavior so only the released tag is pushed.