Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links to current JAXB website and XJC plugins #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ennru
Copy link
Contributor

@ennru ennru commented Oct 18, 2017

  • Added links to current JAXB website and XJC plugins
  • corrected version in Readme


[XJC documentation](https://javaee.github.io/jaxb-v2/doc/user-guide/ch04.html#tools-xjc)

XJC plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's not a lot of context here. why are these relevant to users of this project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this plugin calls the XJC tool to do its work. Command line arguments are passed through to XJC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no documentation on the jaxb2-commons repo. I feel that linking to it with no documentation would be very confusing for our users

There's documentation for the second project: https://mklemm.github.io/jaxb2-rich-contract-plugin/usage.html. However, this documentation is all for a Maven project. I feel that if we're going to reference it from this project we should show how you would use it with sbt-xjc

Copy link
Contributor Author

@ennru ennru Nov 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Java EE documentation seems to be in a very bad state since its move to github.
I found those links helpful while re-configuring our build with sbt-xjc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants