This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Be more aggressive when checking if a log message should be sent to the underlying logger #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbt/sbt#3711 has shown that substantial amount of time is spent calculating log messages that are unlikely to be displayed.
This PR introduces checks that filter out log events for disabled log levels.
It does this on two levels of abstraction which may be redundant and is deserving of critical review. The reason for this is there is non-trivial message construction is happening in
ManagedLogger
but to me changingAbstractLogger
would offer a more general solution for all types of loggers.Lastly, I upgraded the versions of scala as well as the scalafmt plugin.