Infinite Compile Fix #1182
Merged
Infinite Compile Fix #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s include recomplied classes in the next incremental compile round
|
At least one commit author ([email protected]) is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
anmalysh-yb
added a commit
to yugabyte/yugabyte-db
that referenced
this pull request
Jun 23, 2023
… issue workaround Summary: We had to apply a workaround, which turhed off incremental compile in some cases, to deal with sbt/zinc#1182. Now, once 1.8.3 with zinc fix is released - we can remove the workaround. Test Plan: sbt cleanPlatform compilePlatform. Change few files in a codebase. sbt compile Reviewers: sagarwal, shagarwal Reviewed By: shagarwal Subscribers: yugaware Differential Revision: https://phorge.dev.yugabyte.com/D26388
anmalysh-yb
added a commit
to yugabyte/yugabyte-db
that referenced
this pull request
Jun 23, 2023
…emental compile issue workaround Summary: We had to apply a workaround, which turhed off incremental compile in some cases, to deal with sbt/zinc#1182. Now, once 1.8.3 with zinc fix is released - we can remove the workaround. Original diff: https://phorge.dev.yugabyte.com/D26388 Test Plan: sbt cleanPlatform compilePlatform. Change few files in a codebase. sbt compile Reviewers: shagarwal Reviewed By: shagarwal Subscribers: yugaware Differential Revision: https://phorge.dev.yugabyte.com/D26389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the infinite compile, when we have transitive invalidations include recomplied classes in the next incremental compile round.
This fix has been validated in production at Visier for the past month
Resolves: