Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NPE in DelegatingReporter.scala #1246

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix NPE in DelegatingReporter.scala #1246

merged 2 commits into from
Sep 6, 2023

Conversation

unkarjedy
Copy link
Contributor

fixes #1245

@eed3si9n
Copy link
Member

eed3si9n commented Sep 5, 2023

Thanks for the contribution!

Commented on

if ((pos eq null) || pos.isRange) Nil

earlier but deleted, since it didn't show up in the PR but looks like you saw it.

eed3si9n
eed3si9n approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkarjedy!

@eed3si9n
Copy link
Member

eed3si9n commented Sep 5, 2023

Looks like scalafmt is failing, but apart from that LGTM

@eed3si9n eed3si9n merged commit 196376e into sbt:develop Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in xsbt.DelegatingReporter.getActions
2 participants
@unkarjedy @eed3si9n