Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending scripted test for #616 #1305

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add pending scripted test for #616 #1305

merged 1 commit into from
Dec 19, 2023

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Dec 7, 2023 •
edited
Loading

The PR adds pending scripted test for #616

Test log for added test

[error] ${BASE}/Foo.scala:9:13: could not find implicit value for parameter baz: sbt.zinc.example.Baz
[error]     val f = new Foo
[error]             ^
[error] one error found
[debug] Compilation failed (CompilerInterface)
[error] sbt.internal.inc.BatchScriptRunner$PreciseScriptedError: {line 6} Command failed: 'compile'
[error] Caused by: Compilation failed
[error] 	at sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:339)
[error] 	at sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:425)

eed3si9n
eed3si9n approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Friendseeker
Add pending scripted test for zinc#616
a8a44a8 
Further minimize

Fix comment
@Friendseeker Friendseeker force-pushed the default-namespace-implicit branch from 10b9dd7 to a8a44a8 Compare December 7, 2023 20:23
@eed3si9n eed3si9n merged commit 1c809a6 into sbt:develop Dec 19, 2023
7 checks passed
@Friendseeker Friendseeker deleted the default-namespace-implicit branch December 19, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Friendseeker @eed3si9n