Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for #1234 #1318

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Add unit test for #1234 #1318

merged 1 commit into from
Dec 30, 2023

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Dec 30, 2023 •
edited
Loading

Add unit test for #1234

The added test fails on zinc without #1293:

[info] IncrementalCompilerSpec:
[info] incremental compiler
[info] - should delete all products if extra changes *** FAILED ***
[info]   java.nio.file.Files.notExists(p) was false /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_9d140ac7/classes/pkg/Good$.class exist (BaseCompilerSpec.scala:27)

@Friendseeker Friendseeker marked this pull request as ready for review December 30, 2023 07:21
eed3si9n
eed3si9n approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 2718fe3 into sbt:develop Dec 30, 2023
7 checks passed
@Friendseeker Friendseeker deleted the zinc-1234-test branch December 30, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Friendseeker @eed3si9n