-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Merge 1.x branch into 2.x #1433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1.x] Avoid using ZipError
Copy bytes directly instead of using `scala.reflect.io.Streamable`
Probably not needed anymore but better safe than sorry
Update sbt, util-control, util-interface, ... to 1.10.2
Update scalacheck to 1.18.1
[1.x] Run `AnalysisFormatBenchmark` during CI
[1.x] Add missing condition for `AnalysisFormatBenchmark` CI run
Zinc does not provide a way to surface list of all problems present in a codebase. This PR builds SourceInfos in Analysis Callback and in `handleErrors`, the compiler bridge then throws an exception containing the SourceInfos so build tools like sbt can access the informations. Closes sbt#932
[1.x] Emit `SourceInfos` when incremental compilation fails
[1.x] Use `hashCode` instead of XOR hash in `extraHash` computation
…-fast-pass-2 [1.x] Refine early return condition in `invalidateAfterInternalCompilation`
[1.x] Add log for third class invalidation
[1.x] ask Scala Steward not to update `jgit` version
…ckport [1.x] Backport dummy output jar handling for Consistent Analysis Format
…t#1462) Ref sbt#1284 Fixes sbt#1461 Fixes sbt#1420 Also fixes com-lihaoyi/mill#3748 downstream Not sure if there's a better way to fix this? Just opening this to spark discussion The original bugs are fine, but the solution seems incorrect, and is both overly conservative (invalidating everything based on whitespace?) and not conservative enough (doesn't handle cycles with length > 2?).
[1.x] Remove unnecessary `setup-sbt` call
[1.x] Clean compile warnings
[1.x] deps: util 1.10.3
[1.x] avoid deprecated collection.mutable.MultiMap
…ashmap [1.x] avoid deprecated `mutable.OpenHashMap`
I want to get this merged to 2.x. Could we comment out the failing benchmark? |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes up to 0787c42