Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up sbt-release-early and change build semantics #429

Closed
wants to merge 20 commits into from
Closed

Set up sbt-release-early and change build semantics #429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
62a0cb2
Add headers to missing files
jvican Nov 20, 2017
8d60f1f
Move the logic from `build.sbt` to the build plugin
jvican Oct 11, 2017
59392e4
Address Dale's feedback
jvican Oct 12, 2017
fc859fa
Add checks, remove defaults and add headers to test sources
jvican Oct 12, 2017
d46f22b
Add build information to the CONTRIBUTING guide
jvican Oct 12, 2017
2ad8ac6
Add project structure diagram to the guide
jvican Oct 12, 2017
fd34606
Address last piece of feedback from Dale
jvican Oct 12, 2017
e9114f2
Add sbt-release-early
jvican Oct 12, 2017
96519ab
Set up sbt-release-early
jvican Oct 12, 2017
20760f5
Add reasonable jvmopts for all users
jvican Oct 17, 2017
98baaad
Add cached `publishLocal` to zinc
jvican Oct 17, 2017
2b65a81
Remove dead code
jvican Oct 17, 2017
e7d3830
Make the build `+`-friendly
jvican Nov 13, 2017
8b00dca
Remove `crossTestBridges` and `publishBridgesAndSet`
jvican Oct 17, 2017
8327668
Simplify comments in the `build.sbt`
jvican Oct 18, 2017
419d596
Add build changes to the the CONTRIBUTING guide
jvican Oct 18, 2017
8af454f
Remove unnecessary filter for `scriptedPublish`
jvican Nov 13, 2017
0d58234
Scope to the project instead of the build
jvican Nov 13, 2017
543dcb0
Remove use of the `Keys` prefix
jvican Oct 27, 2017
af3fa21
Use scripted resolver in ALL tests
jvican Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/run-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ sbt -Dfile.encoding=UTF-8 \
test:scalafmt::test \
headerCheck \
test:headerCheck \
++2.10.11 \
compilerInterface/compile \
zincRoot/test:compile \
crossTestBridges \
"publishBridgesAndSet $SCALA_VERSION" \
Expand Down
6 changes: 1 addition & 5 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,7 @@ lazy val compilerInterface = (project in internalPath / "compiler-interface")
.settings(
// javaOnlySettings,
name := "Compiler Interface",
// Use the smallest Scala version in the compilerBridgeScalaVersions
// Technically the scalaVersion shouldn't have any effect since scala library is not included,
// but given that Scala 2.10 compiler cannot parse Java 8 source, it's probably good to keep this.
crossScalaVersions := Seq(scala210),
scalaVersion := scala210,
crossScalaVersions := bridgeScalaVersions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the release, wouldn't this result to double publishing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I think it would, I'll try it tomorrow and fix it if that's the case.

adaptOptionsForOldScalaVersions,
libraryDependencies ++= Seq(scalaLibrary.value % Test),
exportJars := true,
Expand Down