Ignored javadoc tool error #448
Conversation
raboof
force-pushed
the
ignoredJavadocToolError
branch
2 times, most recently
from
e7f0cee to
142f7aa
Compare
| synchronized { | ||
| val parser = new JavaErrorParser(cwd) | ||
|
|
||
| parser.parseProblems(err, log).foreach(reporter.log(_)) |
There was a problem hiding this comment.
Is this right? The old impl interleaved \n's between error messages.
There was a problem hiding this comment.
Hmm, you're right - probably makes sense to add those newlines in err(s: => String) (and add some more tests describing how this is actually called).
| val parser = new JavaErrorParser(cwd) | ||
|
|
||
| parser.parseProblems(err, log).foreach(reporter.log(_)) | ||
| out.split("\n").filter(_ != "").foreach(log.info(_)) |
There was a problem hiding this comment.
Are you purposely splitting info messages by newlines to send them independently to log.info?
Why not, instead of concat-ing info messages and then re-splitting, just collect the messages into a list buffer and then iterate that list into log.info?
There was a problem hiding this comment.
Hmm, for some reason I got the impression that we couldn't assume out would be called in neatly framed chunks, but indeed looking at the previous implementation again it appears that we in fact can. In that case a ListBuffer indeed makes more sense, I'll update accordingly!
|
The validator has checked the following projects against Scala 2.12,
✅ The result is: SUCCESS |
| parser.parseProblems(input, log).foreach(reporter.log) | ||
| } | ||
|
|
||
| def flush(exitCode: Int): Unit = { |
There was a problem hiding this comment.
Looks like we can drop this method, but we need to tell MiMa to ignore it.
raboof
force-pushed
the
ignoredJavadocToolError
branch
from
6283df4 to
6b4af5a
Compare
|
(rebased, unfortunately it seems that triggered github to 'dismiss' the review :/) |
|
Hey @raboof thanks! Can you squash all the commits? The previous commits to the formatting are not passing in the CI, and it seems that this fix could be all in one commit. |
When the javadoc tool fails with an error that could not be parsed, the error was silently dropped.
raboof
force-pushed
the
ignoredJavadocToolError
branch
from
6b4af5a to
c8c20ac
Compare
|
Sure, done! |
Reported under #415