-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable coverage when viaIR
compiler flag is true
#854
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 95.92% 95.77% -0.16%
==========================================
Files 19 19
Lines 981 1017 +36
==========================================
+ Hits 941 974 +33
- Misses 40 43 +3 ☔ View full report in Codecov by Sentry. |
E2E tested against 1inch solidity-utils and got the output below. NB: there was a failing test that looked at gas specific values - to be expected because the instrumentation mechanism changed and there's some consumption variance. |
viaIR
compiler flag is trueviaIR
compiler flag is true
PUBLISHED at the viaIR tag
#853, #848, #790, #715, #417
Uses solidity built-in ignored by the yul optimizer to preserve instrumentation when
viaIR
is set to true. This should address all the insane optimizer config problems.Coverage in the plugin's own tests is missing for an edge case where the optimizer has:
... we hit the first two conditions in the integration tests but the hash is a duplicate.
TODO
e2e test on Zeppelin with viaIR flag set to true and verify coverage is identicalviaIR
to true in solc results in zero coverage #715 (comment))Add tests for file-level function declarations (weirdly missing)