Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Currently walletconnect uses web3-provider-engine that has mixed imports #5

Closed
Tracked by #23
ShravanSunder opened this issue Oct 4, 2021 · 1 comment
Closed
Tracked by #23
Assignees

Comments

@ShravanSunder
Copy link
Member

ShravanSunder commented Oct 4, 2021

need to find a solution for building mixed es6 and commonjs files due to web3-provider-engine.

See:

Notes:

Shravan, [04.10.21 16:42]
looks like the web3-provider-engine is a problem in many places

Shravan, [04.10.21 16:42]
portis-project/web-sdk#75

Shravan, [04.10.21 16:42]
WalletConnect/walletconnect-monorepo#310

Shravan, [04.10.21 16:42]
aragon/use-wallet#73

Shravan, [04.10.21 16:43]
i think it impacts webpack 5 as well. mostly because walletconnect depends on web3-provider-engine and its not maintained

Shravan, [04.10.21 16:46]
i think the solution is to use esm imports for any external providers like wallet connect, portis etc

@ShravanSunder ShravanSunder self-assigned this Oct 4, 2021
ShravanSunder added a commit that referenced this issue Oct 4, 2021
ShravanSunder added a commit that referenced this issue Oct 4, 2021
ShravanSunder added a commit that referenced this issue Oct 4, 2021
@ShravanSunder
Copy link
Member Author

ShravanSunder commented Oct 4, 2021

see PR #2 for commits

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant