Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updates.limit option to be zero #1828

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Dec 22, 2020

This allows the repo config option updates.limit to be zero so that it
can now be zero or positive instead of positive only. A zero
updates.limit means that Scala Steward will not create or update PRs.
It can be used to temporarily disable Scala Steward in a repo or if it
is used in the default repo config it would be similar to a hypothetical
dry-run option.

This allows the repo config option `updates.limit` to be zero so that it
can now be zero or positive instead of positive only. A zero
`updates.limit` means that Scala Steward will not create or update PRs.
It can be used to temporarily disable Scala Steward in a repo or if it
is used in the default repo config it would be similar to a hypothetical
dry-run option.
@fthomas fthomas added the enhancement New feature or request label Dec 22, 2020
@fthomas fthomas added this to the 0.9.0 milestone Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1828 (1d4f890) into master (055819b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
+ Coverage   74.87%   74.89%   +0.01%     
==========================================
  Files         123      123              
  Lines        2078     2079       +1     
  Branches       53       57       +4     
==========================================
+ Hits         1556     1557       +1     
  Misses        522      522              
Impacted Files Coverage Δ
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 4.90% <100.00%> (ø)
...g/scalasteward/core/repoconfig/UpdatesConfig.scala 100.00% <100.00%> (ø)
...ain/scala/org/scalasteward/core/util/package.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055819b...1d4f890. Read the comment docs.

@fthomas fthomas merged commit 0940c25 into master Dec 23, 2020
@fthomas fthomas deleted the topic/non-neg-updates-limit branch December 23, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant