Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold back artifacts published with sbt 1.9.5 #3169

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Sep 15, 2023

These libraries where published with sbt 1.9.5 and should not be advertisted by scala-steward since they might be broken, see sbt 1.9.5 release notes:

Update: ⚠️ sbt 1.9.5 is broken, because it causes Scala compiler to generate wrong class names for anonymous class on lambda. While we investigate please refrain from publishing libraries with it.
scala/bug#12868 (comment)

Also see

@mkurz
Copy link
Contributor Author

mkurz commented Sep 15, 2023

@fthomas @mzuehlke @alejandrohdezma can you please merge? Thanks!

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3a81d8e) 91.07% compared to head (2872d5b) 91.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         163      163           
  Lines        3406     3406           
  Branches      284      284           
=======================================
  Hits         3102     3102           
  Misses        304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzuehlke mzuehlke merged commit 15ad2e2 into scala-steward-org:main Sep 15, 2023
@mzuehlke mzuehlke added this to the 0.26.0 milestone Sep 15, 2023
@mkurz mkurz deleted the ignore_play_releases_sbt_195 branch September 15, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants